Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Spring Boot, Apollo, Apollo 3, JUL, Logback, Log4j2, OpenFeign, GraphQL and Kotlin coroutines core dependencies to compileOnly #2837

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Change Spring Boot, Apollo, Apollo 3, JUL, Logback, Log4j2, OpenFeign, GraphQL and Kotlin coroutines core dependencies to compileOnly #2837

merged 6 commits into from
Jul 13, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jul 12, 2023 •
edited
Loading

📜 Description

Switch dependencies that will be auto installed to compileOnly.

💡 Motivation and Context

To enable auto install and address getsentry/sentry-android-gradle-plugin#521 (review)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fea69a1

@adinauer adinauer mentioned this pull request Jul 12, 2023
Merged
4 tasks
@adinauer adinauer changed the title Convert some dependencies to compileOnly Change GraphQL and Kotlin coroutines core dependencies to compileOnly Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (adf8fe3) 81.29% compared to head (fea69a1) 81.29%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #2837   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity     4565     4565           
=========================================
  Files           351      351           
  Lines         16874    16874           
  Branches       2272     2272           
=========================================
  Hits          13717    13717           
  Misses         2216     2216           
  Partials        941      941

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn
Copy link
Member

romtsn commented Jul 12, 2023

I think we should make compileOnly all of those that are gonna be auto-installed, right? Or why have you chosen only these two? 🙂

@adinauer adinauer changed the title Change GraphQL and Kotlin coroutines core dependencies to compileOnly Change Spring Boot, Apollo, Apollo 3, JUL, Logback, Log4j2, OpenFeign, GraphQL and Kotlin coroutines core dependencies to compileOnly Jul 13, 2023
@adinauer
Copy link
Member Author

adinauer commented Jul 13, 2023 •
edited
Loading

🙈 I'm blind / can't use search. Thanks 🙏 . Updated

romtsn
romtsn approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adinauer adinauer merged commit f18a438 into main Jul 13, 2023
19 checks passed
@adinauer adinauer deleted the feat/compile-only-deps branch July 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @romtsn